This is an automated email from the ASF dual-hosted git repository. tomaswolf pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mina-sshd.git
commit 0da17757a0bd7f0574b1568b8e921066d5535bc5 Author: Thomas Wolf <[email protected]> AuthorDate: Sun Jul 5 16:16:03 2026 +0200 GH-906: Fix finding a signature factory for BC ed25519 keys This is a backport of a fix done in 3.0.0-M1. Bouncy Castle ed25519 keys return "Ed25519" from getAlgorithm() unless option org.bouncycastle.emulate.oracle=true is set. --- CHANGES.md | 1 + .../main/java/org/apache/sshd/common/signature/SignatureFactory.java | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 231c88e10..9986a6583 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -33,6 +33,7 @@ ## Bug Fixes +* [GH-906](https://github.com/apache/mina-sshd/issues/906) Fix finding a signature factory for BC ed25519 keys ## New Features diff --git a/sshd-common/src/main/java/org/apache/sshd/common/signature/SignatureFactory.java b/sshd-common/src/main/java/org/apache/sshd/common/signature/SignatureFactory.java index 6876856e5..e2a1bf681 100644 --- a/sshd-common/src/main/java/org/apache/sshd/common/signature/SignatureFactory.java +++ b/sshd-common/src/main/java/org/apache/sshd/common/signature/SignatureFactory.java @@ -236,7 +236,8 @@ public interface SignatureFactory extends BuiltinFactory<Signature> { } else if (algo.contains("rsa")) { factory = BuiltinSignatures.fromFactoryName(algo); } - } else if (SecurityUtils.EDDSA.equalsIgnoreCase(pubKey.getAlgorithm())) { + } else if (SecurityUtils.EDDSA.equalsIgnoreCase(pubKey.getAlgorithm()) + || SecurityUtils.ED25519.equalsIgnoreCase(pubKey.getAlgorithm())) { factory = BuiltinSignatures.ed25519; }
