leezu edited a comment on pull request #18801:
URL: https://github.com/apache/incubator-mxnet/pull/18801#issuecomment-670050013
> But as I've mentioned earlier - GCC 7.5.0 provided by ubuntu doesn't
trigger this error.
Thank you for confirming this @bgawrych. Actually Ubuntu backported the fix
to their GCC 7 version:
```
gcc-7 (7.3.0-3ubuntu1) bionic; urgency=medium
* Update to SVN 20180209 (r257526) from the gcc-7-branch.
- S/390: Disable branch prediction for indirect branches.
- Fix PR tree-optimization/84233 (closes: #889724),
PR target/PR84295 (s390), PR target/84113 (PPC).
* Fix PR c++/83204, taken from the trunk. Closes: #882855.
```
One option is to require GCC8 on non-Ubuntu machines. WDYT? For the CI, we
just need to replace all occurrences of `devtoolset-7` with `devtoolset-8` in
https://github.com/apache/incubator-mxnet/blob/95fa63f765f33b13c29c7b1c0822d2502eb16721/ci/docker/runtime_functions.sh
and
https://github.com/apache/incubator-mxnet/blob/a3eabf0d29eaeb03766dd52ef403650a4804f369/ci/docker/Dockerfile.build.centos7
But before that, @bgawrych @vpirogov could you please try adding the
`target_compile_features(dnnl PUBLIC cxx_std_11)` line here:
https://github.com/apache/incubator-mxnet/blob/a3eabf0d29eaeb03766dd52ef403650a4804f369/CMakeLists.txt#L278-L279
Thereby we use CXX11 standard to compile DNNL, which should avoid the bug in
gcc7.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
