szha commented on a change in pull request #18385:
URL: https://github.com/apache/incubator-mxnet/pull/18385#discussion_r466788279
##########
File path: tests/python/gpu/test_operator_gpu.py
##########
@@ -1547,47 +1551,91 @@ def test_embedding_helper(data_types, weight_types,
low_pad, high_pad):
@with_seed()
def test_take_with_type():
sym = mx.sym.take(name='take')
- for data_ndim in range(2, 5):
- for idx_ndim in range(1, 4):
- data_shape = ()
- for _ in range(data_ndim):
- data_shape += (np.random.randint(low=3, high=6), )
- idx_shape = ()
- for _ in range(idx_ndim):
- idx_shape += (np.random.randint(low=3, high=5), )
- ctx_list = [{'ctx': mx.gpu(0), 'take_indices': idx_shape,
- 'take_a': data_shape,
- 'type_dict': {'take_indices': np.float64,
- 'take_a': np.float64}},
- {'ctx': mx.gpu(0), 'take_indices': idx_shape,
- 'take_a': data_shape,
- 'type_dict': {'take_indices': np.float32,
- 'take_a': np.float32}},
- {'ctx': mx.gpu(0), 'take_indices': idx_shape,
- 'take_a': data_shape,
- 'type_dict': {'take_indices': np.float16,
- 'take_a': np.float16}},
- {'ctx': mx.cpu(0), 'take_indices': idx_shape,
- 'take_a': data_shape,
- 'type_dict': {'take_indices': np.float64,
- 'take_a': np.float64}},
- {'ctx': mx.cpu(0), 'take_indices': idx_shape,
- 'take_a': data_shape,
- 'type_dict': {'take_indices': np.float32,
- 'take_a': np.float32}},
- {'ctx': mx.cpu(0), 'take_indices': idx_shape,
- 'take_a': data_shape,
- 'type_dict': {'take_indices': np.float16,
- 'take_a': np.float16}}]
- arg_params = {'take_indices': np.random.randint(low=0,
- high=data_shape[0],
- size=idx_shape),
- 'take_a': np.random.normal(size=data_shape)}
- check_consistency(sym, ctx_list,
- grad_req={'take_indices': 'null',
- 'take_a': 'write'},
- arg_params=arg_params)
-
+ for safe_accumulation in ['0', '1', None]:
+ for data_ndim in range(2, 5):
+ for idx_ndim in range(1, 4):
Review comment:
use `pytest.mark.parametrize(...)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
