Kh4L commented on a change in pull request #18894:
URL: https://github.com/apache/incubator-mxnet/pull/18894#discussion_r472391503
##########
File path: example/extensions/lib_custom_op/gemm_lib.cc
##########
@@ -159,7 +161,7 @@ MXReturnValue inferShape(const
std::unordered_map<std::string, std::string>& att
unsigned kk = inshapes->at(1)[0];
unsigned m = inshapes->at(1)[1];
if (k != kk) {
- std::cout << "Exected first input axis 1 equals to second input axis 0" <<
std::endl;
+ MX_ERROR_MSG << "Exected first input axis 1 equals to second input axis 0";
Review comment:
```suggestion
MX_ERROR_MSG << "Expected first input axis 1 equals to second input axis
0";
```
##########
File path: example/extensions/lib_custom_op/transposerowsp_lib.cc
##########
@@ -73,11 +75,11 @@ MXReturnValue forward(const std::unordered_map<std::string,
std::string>& attrs,
// The data types and storage types of inputs and outputs should be the same.
if(inputs->at(0).dtype != outputs->at(0).dtype ||
inputs->at(0).stype != outputs->at(0).stype) {
- std::cout << "Error! Expected all inputs and outputs to be the same type."
- << "Found input storage type:" << inputs->at(0).stype
- << " Found output storage type:" << outputs->at(0).stype
- << " Found input data type:" << inputs->at(0).dtype
- << " Found output data type:" << outputs->at(0).dtype <<
std::endl;
+ MX_ERROR_MSG << "Error! Expected all inputs and outputs to be the same
type."
+ << "Found input storage type:" << inputs->at(0).stype
+ << " Found output storage type:" << outputs->at(0).stype
Review comment:
Unwanted whitespaces?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
