szha commented on a change in pull request #18987:
URL: https://github.com/apache/incubator-mxnet/pull/18987#discussion_r475991763
##########
File path: src/storage/storage.cc
##########
@@ -67,8 +67,9 @@ StorageManager *CreateStorageManager(const Context &ctx,
const char *context,
int num_gpu_device, std::string
*pStrategy) {
const auto env_var = env_var_name(context, pool_type);
const char *type = getenv(env_var.c_str());
- if (type == nullptr)
- type = "Naive"; // default pool
+ if (type == nullptr) {
+ type = "Round"; // default pool
Review comment:
I share the concern on this. This change will impact those static-size
static-graph models that were at the boundary of GPU memory limit. How many of
the current GluonCV model training scripts fall in this category?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
