leezu commented on a change in pull request #17559:
URL: https://github.com/apache/incubator-mxnet/pull/17559#discussion_r476846045
##########
File path: CMakeLists.txt
##########
@@ -278,6 +285,15 @@ if(USE_MKLDNN)
set_target_properties(dnnl PROPERTIES CXX_CLANG_TIDY "") # don't lint
3rdparty dependency
endif()
+if(USE_INTGEMM)
+ message(STATUS "Using intgemm")
+ add_subdirectory(3rdparty/intgemm)
Review comment:
Do we expect a large number of users to compile with intgemm? If not,
why force all users to download intgemm instead of making it optional?
```
FetchContent_Declare(
intgemm
GIT_REPOSITORY https://github.com/kpu/intgemm.git
GIT_TAG 77095a0cd5da8a22c4e7ed77588b527d3ee4ada9
)
FetchContent_GetProperties(intgemm)
if(NOT intgemm_POPULATED)
FetchContent_Populate(intgemm)
add_subdirectory(${intgemm_SOURCE_DIR} ${intgemm_BINARY_DIR})
endif()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
