wkcn commented on a change in pull request #19013:
URL: https://github.com/apache/incubator-mxnet/pull/19013#discussion_r476920915
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -1005,33 +1006,44 @@ def test_dlpack():
assert C[0][100] == 101
@use_np
[email protected](reason='broken on large tensors')
-#TODO add 3d pooling test after large tensor is fixed
def test_pooling():
- A = np.ones((1, 2, INT_OVERFLOW))
- A[0][0][2] = 100
+ def test_pooling_large_dim():
+ A = np.ones((1, 1, INT_OVERFLOW))
+ assertRaises(MXNetError, npx.pooling, data=A, kernel=(2), stride=(2), \
+ pool_type='max')
+
+ test_pooling_large_dim()
+ A = np.ones((1, 1, 2**12, 2**10, 2**10))
Review comment:
Can you replace the hard code number with a variable?
For example,
```python
C, H, W = 2**12, 2**10, 2**10
A = np.ones((1, 1, C, H, W))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
