szha commented on a change in pull request #18921:
URL: https://github.com/apache/incubator-mxnet/pull/18921#discussion_r479455775
##########
File path: 3rdparty/mshadow/CMakeLists.txt
##########
@@ -59,6 +59,9 @@ endif()
if(USE_CUDNN)
target_compile_definitions(mshadow INTERFACE MSHADOW_USE_CUDNN)
endif()
+if(USE_CUTENSOR)
+ target_compile_definitions(mshadow INTERFACE MSHADOW_USE_CUTENSOR)
+endif()
Review comment:
While I agree that we should have good defaults for build options, I
don't think we should mix any of the build options together. We can't foresee
how downstream users want to use certain features, and easy customization is
essential in accommodating as much of the customized usage as possible. Many
successful projects have a large number of build options for this reason:
https://github.com/opencv/opencv/blob/master/CMakeLists.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
