szha commented on a change in pull request #19037:
URL: https://github.com/apache/incubator-mxnet/pull/19037#discussion_r479688055
##########
File path: tools/pip/setup.py
##########
@@ -164,7 +159,7 @@ def skip_markdown_comments(md):
package_data['mxnet'].append('mxnet/libquadmath.so.0')
if os.path.exists(os.path.join(libdir, 'libopenblas.so.0')):
shutil.copy(os.path.join(libdir, 'libopenblas.so.0'), mxdir)
- package_data['mxnet'].append('mxnet/libquadmath.so.0')
+ package_data['mxnet'].append('mxnet/libopenblas.so.0')
Review comment:
this part looked wrong as it adds openblas in but records quadmath
instead. it's likely not triggered as we didn't switch to dynamic linking with
openblas for distribution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
