marcoabreu commented on a change in pull request #19016:
URL: https://github.com/apache/incubator-mxnet/pull/19016#discussion_r479800261
##########
File path: src/initialize.cc
##########
@@ -97,9 +97,7 @@ LibraryInitializer::LibraryInitializer()
install_pthread_atfork_handlers();
}
-LibraryInitializer::~LibraryInitializer() {
- close_open_libs();
-}
+LibraryInitializer::~LibraryInitializer() = default;
Review comment:
Right, but hence an assertion or some other debug log to make the user
aware that there are still unclosed handles. The idea is to give a hint during
shutdown. If somebody then sees hundreds of unclosed handles, that could be a
strong indicator of something being wrong - I'm not talking about automatic
closing of the handle, just a message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
