josephevans commented on a change in pull request #19017:
URL: https://github.com/apache/incubator-mxnet/pull/19017#discussion_r482709852
##########
File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
##########
@@ -945,17 +1006,35 @@ def convert_dropout(node, **kwargs):
and return the created node.
"""
name, input_nodes, attrs = get_inputs(node, kwargs)
+ opset_version = kwargs["opset_version"]
Review comment:
That is an option, but not all operators changed with newer opset
versions. I think it's best, for now, to just extract the opset_version for
operators that need to know about it. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
