leezu commented on a change in pull request #18704:
URL: https://github.com/apache/incubator-mxnet/pull/18704#discussion_r485222910
##########
File path: src/imperative/imperative.cc
##########
@@ -233,7 +233,7 @@ void Imperative::RecordOp(
nnvm::ObjectPtr node = nnvm::Node::Create();
node->attrs = std::move(attrs);
- node->attrs.name = "node_" + std::to_string(node_count_++);
+ node_count_ += 1;
Review comment:
The example you give relies on the NameManager feature, which is only
available in symbolic API. Note that autograd and dc do not apply to the
symbolic API, thus they will not overwrite names set by the NameManager. That's
why the names are generated via `node_count_ += 1;`, which you now deleted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
