kpuatamazon commented on pull request #19099: URL: https://github.com/apache/incubator-mxnet/pull/19099#issuecomment-691994392
Hi sorry I work Mondays on this. The issues are all around older compilers and getting `Makefile` to work. `gcc` below 5 doesn't support avx2 intrinstics well, so I want to disable intgemm compilation below that. Any comments on how best to test for this, keeping in mind that gcc can have many different `CXX` names? I was thinking about a compilation test. But at least in 2.x, MXNet fetches intgemm so I figured the Makefile would do the same with a target that does a `git checkout`. Which means any intgemm compilation tests are not available at the time `Makefile` is deciding whether to download stuff. Currently I have a rather hacky test in the `Makefile`. Is there somewhere in the main repo to put a compilation test? Regarding debug and `_mm512_slli_epi16` that should be fixed now. It requires a constant shift argument. Compiler versions differ in their willingness to see a constant through a function call, especially in debug. I've changed it to a template argument to force the constant to be passed through function calls. Windows should be fixed. It just didn't have `pytest` so `import pytest` was failing. I've removed the dependency on `pytest`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
