Zha0q1 commented on pull request #19059: URL: https://github.com/apache/incubator-mxnet/pull/19059#issuecomment-692402390
> @Zha0q1 Can you change names of variables from A,B,C to input, output and input.grad ? its not good practice to use these variable names. Or link a new PR to address this issue in the PR. I created this PR https://github.com/apache/incubator-mxnet/pull/19147/files. After prioritizing full coverage we can tweak the naming in this wip pr for better readability ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
