DickJC123 opened a new pull request #19175: URL: https://github.com/apache/incubator-mxnet/pull/19175
During the 1.x backporting of master-branch PR https://github.com/apache/incubator-mxnet/pull/19123 (as PR https://github.com/apache/incubator-mxnet/pull/19158), some issues were discovered and corrected. This PR "forward ports" the result so that the logic behind use of fatbin compression remains consistent between master and v1.x. Currently, master has the following issues: If CMAKE_CUDA_FLAGS were already set, to say "--foo=bar", then that env var would be altered incorrectly to "--foo=bar--fatbin-options -compress-all" Also, if USE_SPLIT_ARCH_DLL=OFF and MSVC=1, there would be no fatbin compression, even with USE_FATBIN_COMPRESSION=ON. This PR corrects these issues, and so makes master behave like v1.x. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
