kpuatamazon opened a new pull request #19202:
URL: https://github.com/apache/incubator-mxnet/pull/19202


   ## Description ##
   This is a twin of #19201 to fix #19197.  I made a flaky test, sorry.  
   
   It's testing a quantizer that entails rounding but rounding 0.5 is 
ambiguous.  So I intended to ban 0.5 by adding a small value.  The code checks 
the interval (0.45, 0.55) and adds 0.05 to anything there.  But that just 
shifts it to (0.5, 0.6) when I meant to go further from 0.5.  Now it shifts to 
(0.65, 0.75) so 0.5 won't appear.  
   
   ## Checklist ##
   ### Essentials ###
   - [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], 
[FEATURE], [DOC], etc)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] Code is well-documented
   
   ### Changes ###
   Fix flaky test `test_contrib_intgemm_prepare_data`
   
   ## Comments ##
   Another approach would be to allow some tolerance for quantized values 
around 0.5.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to