wkcn commented on a change in pull request #19147:
URL: https://github.com/apache/incubator-mxnet/pull/19147#discussion_r493104353
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -90,28 +90,28 @@ def test_softmax():
@use_np
def test_ones():
- A = np.ones((INT_OVERFLOW, 2))
- assert A.shape == (INT_OVERFLOW, 2)
- assert A[0][0] == 1
+ data = np.ones((INT_OVERFLOW, 2))
Review comment:
`input` is a built-in function of python. I think `data` is better.
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -90,28 +90,28 @@ def test_softmax():
@use_np
def test_ones():
- A = np.ones((INT_OVERFLOW, 2))
- assert A.shape == (INT_OVERFLOW, 2)
- assert A[0][0] == 1
+ data = np.ones((INT_OVERFLOW, 2))
Review comment:
`input` is a built-in function in python. I think `data` is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
