marcoabreu commented on a change in pull request #19244: URL: https://github.com/apache/incubator-mxnet/pull/19244#discussion_r497998263
########## File path: ci/jenkins/Jenkinsfile_website_release ########## @@ -0,0 +1,67 @@ +// -*- mode: groovy -*- + +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// +// Jenkins pipeline +// See documents at https://jenkins.io/doc/book/pipeline/jenkinsfile/ + +// timeout in minutes +max_time = 180 + +node('utility') { + // Loading the utilities requires a node context unfortunately + checkout scm + utils = load('ci/Jenkinsfile_utils.groovy') + custom_steps = load('ci/jenkins/Jenkins_steps.groovy') +} + +utils.assign_node_labels(utility: 'utility', linux_cpu: 'mxnetlinux-cpu') Review comment: None the less, you are giving the pipeline write permissions. Our unrestricted slaves are set up to specifically not be able to persist anything. Otherwise, somebody could go ahead, submit a PR which hijacks a pipeline. They could then go ahead and download illegal content from somewhere and host it in our s3 bucket. Do you want to be responsible for that? Back then, the slaves were specifically set up with an instance profile which prohibited all these actions. You might want to engage in a security review to ensure everything is still safe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
