waytrue17 commented on a change in pull request #19272:
URL: https://github.com/apache/incubator-mxnet/pull/19272#discussion_r498954373
##########
File path: tools/setup_gpu_build_tools.sh
##########
@@ -312,11 +345,16 @@ if [[ ! -d
$DEPS_PATH/usr/local/cuda-${CUDA_MAJOR_VERSION} ]]; then
rm package.deb
done
- mkdir -p ${prefix}/include
- mkdir -p ${prefix}/lib
- cp ${prefix}/usr/include/x86_64-linux-gnu/cudnn_v${LIBCUDNN_MAJOR}.h
${prefix}/include/cudnn.h
- ln -s libcudnn_static_v${LIBCUDNN_MAJOR}.a
${prefix}/usr/lib/x86_64-linux-gnu/libcudnn.a
- cp ${prefix}/usr/local/cuda-${CUDA_MAJOR_VERSION}/lib64/*.a ${prefix}/lib/
- cp ${prefix}/usr/include/nccl.h ${prefix}/include/nccl.h
- ln -s libnccl_static.a ${prefix}/usr/lib/x86_64-linux-gnu/libnccl.a
-fi
+ mkdir -p ${prefix}/include ${prefix}/lib ${prefix}/usr/lib/x86_64-linux-gnu
+ if [[ $LIBCUDNN_MAJOR == 8 ]]; then
+ for h in ${prefix}/usr/include/x86_64-linux-gnu/cudnn_*_v8.h; do
+ newfile=$(basename $h | sed 's/_v8//')
+ cp $h ${prefix}/include/$newfile
+ done
+ fi
+ cp -f ${prefix}/usr/include/x86_64-linux-gnu/cudnn_v${LIBCUDNN_MAJOR}.h
${prefix}/include/cudnn.h
+ ln -sf libcudnn_static_v${LIBCUDNN_MAJOR}.a
${prefix}/usr/lib/x86_64-linux-gnu/libcudnn.a
+ cp -f ${prefix}/usr/local/cuda-${CUDA_MAJOR_VERSION}/lib64/*.a
${prefix}/lib/
+ cp -f ${prefix}/usr/include/nccl.h ${prefix}/include/nccl.h
+ ln -sf libnccl_static.a ${prefix}/usr/lib/x86_64-linux-gnu/libnccl.a
+fi
Review comment:
New line added
##########
File path: tools/pip/setup.py
##########
@@ -215,4 +217,4 @@ def skip_markdown_comments(md):
'Topic :: Software Development :: Libraries',
'Topic :: Software Development :: Libraries :: Python Modules',
],
- url='https://github.com/apache/incubator-mxnet')
+ url='https://github.com/apache/incubator-mxnet')
Review comment:
New line added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
