samskalicky edited a comment on pull request #19241: URL: https://github.com/apache/incubator-mxnet/pull/19241#issuecomment-703778269
I dont think we want to exclude all symbols when building the libmxnet.so, thats why we have the version script. We need to expose some symbols in order to improve the C/C++ building flow and support external components in the future. So making this change will make it harder in the future. Whats the rationale behind switching from version script to exclude all? @leezu looks like the [last change to the version script](https://github.com/apache/incubator-mxnet/blob/master/cmake/libmxnet.ver) was from you that exported symbols needed for Horovod. If we make this change will it break the symbols needed for Horovod, bytePS, etc? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
