ptrendx commented on pull request #19269: URL: https://github.com/apache/incubator-mxnet/pull/19269#issuecomment-704372201
Ok, issue #19264 came at a perfect time - it actually exposed a corner case that breaks both the original and the new algorithm. The minimal example looks like this:  where `a0`, `a1`, `b0` and `b1` are fusable, while `xa` and `xb` are not. According to the original algorithm `a0` and `a1` can be fused together and `b0` and `b1` can be fused together. But if we do that we get:  It happens because the algorithm does not take into account that the exclusion sets of the nodes connected to a subgraph need to contain the excluded nodes from all nodes in that subgraph, even if they were added later in the subgraph creation process. I am working on a solution that will fix that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
