sxjscience commented on a change in pull request #19302:
URL: https://github.com/apache/incubator-mxnet/pull/19302#discussion_r502722859
##########
File path: src/operator/numpy/np_matrix_op-inl.h
##########
@@ -1250,7 +1250,7 @@ void NumpyConcatenateBackward(const nnvm::NodeAttrs&
attrs,
}
struct NumpyDiagParam : public dmlc::Parameter<NumpyDiagParam> {
- int k;
+ index_t k;
Review comment:
Given that we have added the support, it's fine to use index_t.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
