ciyongch commented on a change in pull request #19308:
URL: https://github.com/apache/incubator-mxnet/pull/19308#discussion_r502729378
##########
File path: src/operator/nn/mkldnn/mkldnn_rnn.cc
##########
@@ -47,6 +47,14 @@ inline int GetRnnGatesNum(int mode) {
}
}
+// Bug in oneDNN >= 1.6 in memory descriptor comparision operators.
Review comment:
typo? `oneDNN <= 1.6` here?
##########
File path: src/operator/nn/mkldnn/mkldnn_rnn.cc
##########
@@ -47,6 +47,14 @@ inline int GetRnnGatesNum(int mode) {
}
}
+// Bug in oneDNN >= 1.6 in memory descriptor comparision operators.
+// for specific dims and strides in descriptors == operator can return `true`
+// but get_size() function will return different size
+// TODO(bgawrych): Remove with oneDNN 1.7 upgrade
+bool CheckMemDescEquality(const mkldnn::memory::desc &left, const
mkldnn::memory::desc &right) {
Review comment:
better to make this function as `static inline`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
