DickJC123 opened a new pull request #19328:
URL: https://github.com/apache/incubator-mxnet/pull/19328


   ## Description ##
   This fixes issue https://github.com/apache/incubator-mxnet/issues/19255, 
where it was noted that when a unittest was skipped, the skip-exception caused 
the with_seed() decorator to log the seed. While the 1.8.x branch uses 
nosetests, not pytest, the same behavior is seen on 1.8..x. With this PR the 
seed is no longer logged.
   
   This PR doesn't have any testing added- I will inspect the CI log for 
skipped tests such as test_operator.py:test_activation to verify that the seed 
logging has been successfully eliminated.
   
   This is identical to the master -> 1.x backport PR 
https://github.com/apache/incubator-mxnet/pull/19327.
   
   @leezu @samskalicky
   
   
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], 
[FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be 
made.
   - Interesting edge cases to note here
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to