access2rohit commented on a change in pull request #19324:
URL: https://github.com/apache/incubator-mxnet/pull/19324#discussion_r503753173
##########
File path: src/operator/nn/moments-inl.h
##########
@@ -77,7 +77,7 @@ inline bool MomentsType(const nnvm::NodeAttrs& attrs,
struct VarBroadcastKernel {
template<typename DType>
- MSHADOW_XINLINE static void Map(int i,
+ MSHADOW_XINLINE static void Map(index_t i,
DType *out,
const DType *data,
const DType *mean,
Review comment:
can you change index variables inside the kernels to `index_t` from
`size_t`
##########
File path: src/operator/nn/moments-inl.h
##########
@@ -77,7 +77,7 @@ inline bool MomentsType(const nnvm::NodeAttrs& attrs,
struct VarBroadcastKernel {
template<typename DType>
- MSHADOW_XINLINE static void Map(int i,
+ MSHADOW_XINLINE static void Map(index_t i,
DType *out,
const DType *data,
const DType *mean,
Review comment:
can you change index variables inside the kernel to `index_t` from
`size_t`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
