leezu opened a new pull request #19483:
URL: https://github.com/apache/incubator-mxnet/pull/19483


   Make use of the `_alive` attribute introduced in 
https://github.com/apache/incubator-mxnet/pull/19475 to make check_leak_ndarray 
pytest fixture more robust and precise.
   
   Also handle NotImplementedError in __hash__ in check_leak_ndarray fixture. 
MXNet ndarray throws NotImplementedError in __hash__ Prior to the Segfault fix 
in https://github.com/apache/incubator-mxnet/pull/19475, this was causing 
Segfault https://github.com/apache/incubator-mxnet/issues/19473 as PyTest would 
try to print the array.
   
   See 
https://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/unix-cpu/branches/leezu-patch-3/runs/3/nodes/286/steps/425/log/?start=0
 for NotImplementedError


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to