szha commented on a change in pull request #19417:
URL: https://github.com/apache/incubator-mxnet/pull/19417#discussion_r520868839
##########
File path: python/mxnet/gluon/block.py
##########
@@ -1381,12 +1381,12 @@ def export(self, path, epoch=0, remove_amp_cast=True):
.format(name=name), stacklevel=3)
else:
arg_dict['aux:%s'%name] = param._reduce()
- save_fn = _mx_npx.save if is_np_array() else ndarray.save
+ save_fn = _mx_npx.savez if is_np_array() else ndarray.save
Review comment:
I'm trying to see if there will ever be the case that the behavior of
the quoted statement is wrong. One case I can think of is that parameters are
created with the numpy class while the flag of `is_np_array()` returns false
for some reason. I imagine this is only possible when there's mixed use such as
in parameter sharing, hence the question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
