samskalicky commented on a change in pull request #19543:
URL: https://github.com/apache/incubator-mxnet/pull/19543#discussion_r525580502
##########
File path: python/mxnet/gluon/block.py
##########
@@ -1175,7 +1175,14 @@ def _call_cached_op(self, *args):
out = [out]
return _regroup(out, self._out_format)
- def optimize_for(self, x, *args, backend=None, backend_opts=None,
clear=True, partition_if_dynamic=False, **kwargs):
+ def optimize_for(self, x, *args, backend=None, clear=False,
Review comment:
Building on @waytrue17 's
[comment](https://github.com/apache/incubator-mxnet/pull/19543#discussion_r525553211),
is there any point to calling optimize_for without a backend? or should
backend always be required (and we shouldnt set default to be None). What do
you think @mseth10?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
