Zha0q1 commented on a change in pull request #19174:
URL: https://github.com/apache/incubator-mxnet/pull/19174#discussion_r527256221
##########
File path: tools/dependencies/openblas.sh
##########
@@ -31,7 +31,8 @@ if [[ (! -e $DEPS_PATH/lib/libopenblas.a) ]]; then
cd $DEPS_PATH/OpenBLAS-${OPENBLAS_VERSION}
# Adding NO_DYNAMIC=1 flag causes make install to fail
- CFLAGS="-fPIC" CXXFLAGS="-fPIC" $MAKE DYNAMIC_ARCH=1 DYNAMIC_OLDER=1
USE_OPENMP=1
+ CFLAGS="-fPIC" CXXFLAGS="-fPIC" $MAKE DYNAMIC_ARCH=1 DYNAMIC_OLDER=1
USE_OPENMP=1 \
+ INTERFACE64=1 BINARY=64
Review comment:
> Also Why is it different from here?
https://github.com/apache/incubator-mxnet/pull/19174/files#diff-5ccf6e661bf0b669dd4900b71d988c969259810a3bef5c5376a212f4080186fbR98
>
> ```
> CXX="g++ -fPIC" CC="gcc -fPIC" make -j DYNAMIC_ARCH=1 DYNAMIC_OLDER=1 \
> INTERFACE64=1 BINARY=64 NO_SHARED=0 NO_LAPACK=0 && \
> ```
`NO_SHARED=0 NO_LAPACK=0` are default to 0 anyways. I have removed them to
keep the openblas build commands consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
