leezu opened a new pull request #19596: URL: https://github.com/apache/incubator-mxnet/pull/19596
## Description ## Fixes https://github.com/apache/incubator-mxnet/issues/19595 There was an index offset bug in the branch responsible for large arrays. The bug was introduced when rewriting the `zip_source_buffer_fragment_create` functionality of libzip for miniz. This functionality is important to write multiple buffers (npy header buffer and data buffer) to the same zip entry without extra memory allocation. miniz is more "lowlevel" and doesn't contain such convenience API (but supports inplace appending to a zipfile which is important for writing multiple arrays to same npz file). Turns out the CI didn't test saving large arrays and this bug went unnoticed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
