samskalicky opened a new pull request #19668:
URL: https://github.com/apache/incubator-mxnet/pull/19668


   ## Description ##
   The macros used to define components in Extensions were not using the name 
given. This resulted in duplicate defined symbols when ops, partitioners, or 
graph passes are defined in separate files (ie. compilation units) since the 
counter is reset:
   ```
   CMakeFiles/pass1.cc.o:(.bss+0x0): multiple definition of `MXNet_CustomPass_0'
   CMakeFiles/pass2.cc.o:(.bss+0x0): first defined here
   collect2: error: ld returned 1 exit status
   ```
   This PR fixes this by concatenating the given name of the component to the 
variable name. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to