waytrue17 commented on a change in pull request #19732:
URL: https://github.com/apache/incubator-mxnet/pull/19732#discussion_r554235467
##########
File path: tests/python-pytest/onnx/test_operators.py
##########
@@ -351,3 +351,12 @@ def test_onnx_export_softmax(tmp_path, dtype):
M4 = def_model('softmax', use_length=True, axis=1)
l4 = mx.nd.array([[2,0,3,1],[0,1,0,0]], dtype=int)
op_export_test('softmax_4', M4, [x, l4], tmp_path)
+
+
[email protected]('dtype', ['float16', 'float32', 'float64', 'int32',
'int64'])
[email protected]('axis', [None, 0, 1, 2])
Review comment:
Shall we also test negative axis like -1 or -2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
