leezu commented on a change in pull request #19742:
URL: https://github.com/apache/incubator-mxnet/pull/19742#discussion_r555718298
##########
File path: CMakeLists.txt
##########
@@ -237,6 +237,7 @@ endif()
if(USE_TENSORRT)
message(STATUS "Using TensorRT")
+ execute_process(COMMAND bash tools/dependencies/build_onnx_trt.sh)
Review comment:
Could you clarify why an external script is needed here? Usually we can
use cmake `add_subdirectory(path EXCLUDE_ALL)`. Both onnx and onnx-tensorrt use
cmake, and we can import their targets via `add_subdirectory` and then specify
them as dependency for the mxnet target? The latter may be more robust
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
