josephevans commented on a change in pull request #19736:
URL: https://github.com/apache/incubator-mxnet/pull/19736#discussion_r558739399
##########
File path: tests/python-pytest/onnx/test_operators.py
##########
@@ -338,17 +338,18 @@ def test_onnx_export_cast(tmp_path, src_dtype, dst_dtype,
shape):
@pytest.mark.parametrize('dtype', ['float16', 'float32'])
-def test_onnx_export_softmax(tmp_path, dtype):
[email protected]('temperature', [.1, 1., 10.])
Review comment:
Should we check when temperature is not provided (and should default to
1.0?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
