leezu commented on a change in pull request #19685:
URL: https://github.com/apache/incubator-mxnet/pull/19685#discussion_r562584934
##########
File path: python/setup.py
##########
@@ -81,7 +81,7 @@ def config_cython():
libraries = ['mxnet']
# Default paths to libmxnet.so relative to the shared library file
generated by cython.
# These precede LD_LIBRARY_PATH.
- extra_link_args =
["-Wl,-rpath=$ORIGIN/..:$ORIGIN/../../../lib:$ORIGIN/../../../build"]
+ extra_link_args =
["-Wl,-rpath,$ORIGIN/..:$ORIGIN/../../../lib:$ORIGIN/../../../build"]
Review comment:
Nice catch. Can you change the github actions script to always test the
cython build on os x?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
