bartekkuncer commented on a change in pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#discussion_r592227448
##########
File path: cmake/ChooseBlas.cmake
##########
@@ -23,14 +23,6 @@ set(INTEL_OPT_ROOT "/opt/intel" CACHE PATH "Folder contains
root-installed intel
if(DEFINED USE_BLAS)
set(BLAS "${USE_BLAS}")
-else()
- if (USE_MKL_IF_AVAILABLE)
- # Setting up BLAS_mkl_MKLROOT for non-Ubuntu 20.04 OSes
- find_path(BLAS_mkl_MKLROOT mkl PATHS $ENV{MKLROOT} ${INTEL_HOME_ROOT}
${INTEL_OPT_ROOT})
- if(NOT BLAS_mkl_MKLROOT STREQUAL "BLAS_mkl_MKLROOT-NOTFOUND")
- set(BLAS "MKL")
- endif()
- endif()
Review comment:
Well now if the user wants to use mkl he has to explicitly declare
USE_BLAS=mkl. Otherwise with no BLAS set, OpenBLAS will be used. Do we want to
keep this functionality now as default in mxnet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
