anko-intel commented on a change in pull request #20137:
URL: https://github.com/apache/incubator-mxnet/pull/20137#discussion_r609091716
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -482,6 +481,10 @@ def check_Deconvolution_training(stype):
elif np.array(shape).shape[0] == 4:
test = mx.symbol.Deconvolution(data=data, kernel=(3, 3),
stride=(2, 2), num_filter=4)
weight_tmp = np.random.normal(-0.1, 0.1, size=(3, 4, 3, 3))
+ # not testing stype fallback, as 3D deconvolution is not natively
supported yet
Review comment:
Maybe run the test for 3D only when MLDNN is enabled. I think checking
compile time "MKLDNN" Features will be enough:
https://mxnet.apache.org/versions/1.8.0/api/python/docs/api/mxnet/runtime/index.html
Additionally you can check if MXNET_MKLDNN_ENABLED environment is not set to
false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
