marcoabreu commented on a change in pull request #20138:
URL: https://github.com/apache/incubator-mxnet/pull/20138#discussion_r610026556
##########
File path: ci/Jenkinsfile_utils.groovy
##########
@@ -112,7 +112,18 @@ def get_git_commit_hash() {
}
def publish_test_coverage() {
- sh "curl -s https://codecov.io/bash | bash"
+ // CodeCovs auto detection has trouble with our CIs PR validation due the
merging strategy
+ git_commit_hash = get_git_commit_hash()
+
+ if (env.CHANGE_ID) {
+ // PR execution
+ codecovArgs = "-f '*.xml' -B ${env.CHANGE_TARGET} -P ${env.CHANGE_ID} -C
${git_commit_hash}"
Review comment:
Why is this filter necessary? I think codecov is able to find the
reports on its own and also there might be other coverage reports that are not
xml Files - like gcov..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
