leezu commented on a change in pull request #20146: URL: https://github.com/apache/incubator-mxnet/pull/20146#discussion_r611973124
########## File path: CMakeLists.txt ########## @@ -980,4 +980,11 @@ if(BUILD_CYTHON_MODULES) endif() # https://github.com/apache/incubator-mxnet/issues/20145 -target_compile_definitions(mxnet PRIVATE NVML_NO_UNVERSIONED_FUNC_DEFS) +if(UNIX) + if(USE_NVML) + find_package(NVML) + if(NVML_FOUND) + target_compile_definitions(mxnet PRIVATE NVML_NO_UNVERSIONED_FUNC_DEFS) Review comment: You're right. So you can consider add it after line 660, or move 656-660 to an earlier location in the file. It's not necessary to do it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
