szha commented on a change in pull request #20043:
URL: https://github.com/apache/incubator-mxnet/pull/20043#discussion_r613502383
##########
File path: src/storage/pooled_storage_manager.h
##########
@@ -69,6 +70,11 @@ class GPUPooledStorageManager final : public StorageManager {
LOG(FATAL) << "MXNET_GPU_MEM_POOL_PAGE_SIZE cannot be set to a value
smaller than " << NDEV \
<< ". Got " << page_size_ << ".";
}
+ memory_limit_percentage_ = dmlc::GetEnv<double>("MXNET_GPU_MEM_LIMIT",
100.0);
+ if (memory_limit_percentage_ <= 0 || memory_limit_percentage_ > 100) {
+ LOG(FATAL) << "Invalid memory limit percentage given: " <<
memory_limit_percentage_
+ << std::endl;
+ }
Review comment:
How is this variable semantically different from the
`MXNET_GPU_MEM_POOL_RESERVE` variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
