szha commented on a change in pull request #20188:
URL: https://github.com/apache/incubator-mxnet/pull/20188#discussion_r618041061
##########
File path: 3rdparty/mshadow/mshadow/base.h
##########
@@ -1364,7 +1364,8 @@ struct minimum {
default: \
LOG(FATAL) << "Unknown type enum " << type; \
}
-
+// amp_cast.h is using this MSHADOW_TYPE_SWITCH_WITH_BOOL in order to
+// avoid 'Unsupport enum type 12' error.
Review comment:
I suggest to remove it and then track any todo as a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
