waytrue17 commented on a change in pull request #20226:
URL: https://github.com/apache/incubator-mxnet/pull/20226#discussion_r622596256



##########
File path: tests/python-pytest/onnx/test_operators.py
##########
@@ -1260,8 +1262,11 @@ def test_onnx_export_RNN(tmp_path, mode, dtype, 
state_size, input_size, num_laye
     if mode == 'lstm':
         cell = mx.nd.random.uniform(-1, 1, [num_layers, batch_size, 
state_size], dtype=dtype)
         op_export_test('rnn', M, [x, param, state, cell], tmp_path)
+    elif mode == 'rnn_relu':
+        # set large atol as relu can outputs big numbers
+        op_export_test('rnn', M, [x, param, state], tmp_path, atol=1e20)
     else:
-        op_export_test('rnn', M, [x, param, state], tmp_path)
+        op_export_test('rnn', M, [x, param, state], tmp_path, atol=1e-2)

Review comment:
       From my local runs, the diff is between 1e-3 to 1e-2. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to