[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

[GitBox]

josephevans commented on a change in pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#discussion_r633977583



##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -430,8 +430,7 @@ void MKLDNNConvolutionForwardFullFeature(const 
MKLDNNConvFullParam &param, const
       weight.MKLDNNDataReorderAsync(fwd->GetPd().weights_desc());
       weight_mem = GetWeights(weight, fwd->GetPd().weights_desc(), 
param.conv_param.num_group);
     } else {
-      weight_mem = weight.GetMKLDNNData();
-      CHECK(weight_mem->get_desc() == fwd->GetPd().weights_desc());
+      weight_mem = weight.GetMKLDNNDataReorder(fwd->GetPd().weights_desc());

Review comment:
       Is this change required due to the new oneDNN version or is it a bugfix? 
I ask because we have a customer facing an issue with this check failing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org