leezu commented on a change in pull request #20355:
URL: https://github.com/apache/incubator-mxnet/pull/20355#discussion_r654966757
##########
File path: tools/license_header.py
##########
@@ -110,6 +110,11 @@
# This file
'tools/license_header.py',
+ # Dual-Licensed under Apache 2.0 and Nvidia BSD-3
+ 'python/mxnet/onnx/mx2onnx/_export_onnx.py',
+
'python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset12.py',
+
'python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset13.py',
Review comment:
Dual licensed files should also be mentioned in the root LICENSE file.
Further, as these files start with AL2 License text, why do you need to include
them in `license_header.py`? If the license test fails, would it succeed if
Line 17 (the line after end of AL2 text would be empty instead of `#`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
