akarbown commented on a change in pull request #20340:
URL: https://github.com/apache/incubator-mxnet/pull/20340#discussion_r656065809
##########
File path: src/operator/tensor/dot.cc
##########
@@ -111,6 +115,34 @@ NNVM_REGISTER_OP(_backward_dot)
.set_attr<FComputeEx>("FComputeEx<cpu>", DotBackwardEx<cpu>)
.add_arguments(DotParam::__FIELDS__());
+#if MXNET_USE_ONEDNN == 1
+static void BatchDotComputeExCPU(const nnvm::NodeAttrs& attrs,
+ const OpContext& ctx,
+ const std::vector<NDArray>& inputs,
+ const std::vector<OpReqType>& req,
+ const std::vector<NDArray>& outputs) {
+ if (SupportMKLDNNBatchDot(inputs, outputs[0])) {
+ MKLDNN_OPCHECK_INIT(false, outputs.size(), inputs, outputs);
+ MKLDNNRun(MKLDNNBatchDotForward, attrs, ctx, inputs, req, outputs);
+ MKLDNN_OPCHECK_RUN(BatchDotForward_<cpu>, attrs, ctx, inputs, req,
outputs);
+ return;
+ }
+ FallBackCompute(BatchDotForward_<cpu>, attrs, ctx, inputs, req, outputs);
+}
+
+inline static bool BatchDotStorageType(const nnvm::NodeAttrs& attrs,
Review comment:
How about leaving the 'static' here (without 'inline') so that it will
be visible only in that TU?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
