ptrendx commented on a change in pull request #20331:
URL: https://github.com/apache/incubator-mxnet/pull/20331#discussion_r658483058
##########
File path: include/mxnet/base.h
##########
@@ -348,10 +348,10 @@ struct RunContext {
* \brief the auxiliary stream of the device, can be nullptr or Stream<gpu>*
in GPU mode
*/
void *aux_stream;
- /*!
- * \brief indicator of whether this execution is run in bulk mode
+ /*!
+ * \brief pointer to the cuda event pool used by the dependecy engine
*/
- bool is_bulk;
+ void *event_pool = nullptr;
Review comment:
Leaving this comment here just as a way to explain why the `is_bulk` is
removed. `is_bulk` was a way to mark operations as not needing synchronization
when being a part of a single engine bulk. This PR moves the handling of the
synchronization to the engine itself, so this is no longer useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
