bartekkuncer commented on a change in pull request #20393:
URL: https://github.com/apache/incubator-mxnet/pull/20393#discussion_r659668745
##########
File path: src/operator/subgraph/mkldnn/mkldnn_fc_property.h
##########
@@ -113,13 +113,17 @@ class SgMKLDNNFCSelector : public SubgraphSelector {
}
}
if (!quantized_ && (new_node.op() == Op::Get("square") ||
+ new_node.op() == Op::Get("_npi_square") ||
new_node.op() == Op::Get("sqrt") ||
- new_node.op() == Op::Get("exp"))) {
+ new_node.op() == Op::Get("_npi_sqrt") ||
+ new_node.op() == Op::Get("exp") ||
+ new_node.op() == Op::Get("_npi_exp"))) {
matched_list_.push_back(&new_node);
status_ = kSuccess;
return true;
}
- if (new_node.op() == Op::Get("abs")) {
+ if (new_node.op() == Op::Get("abs") ||
+ new_node.op() == Op::Get("_npi_absolute")) {
Review comment:
If you change something I think it would be nice to put those checks in
pairs e.g. `if (new_node.op() == Op::Get("abs") || new_node.op() ==
Op::Get("_npi_absolute")) {` or `new_node.op() == Op::Get("exp") ||
new_node.op() == Op::Get("_npi_exp")`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
