szha commented on a change in pull request #20372:
URL: https://github.com/apache/incubator-mxnet/pull/20372#discussion_r661069338
##########
File path: src/operator/tensor/elemwise_unary_op_basic.cc
##########
@@ -161,10 +161,34 @@ The storage type of ``log_sigmoid`` output is always dense
)code" ADD_FILELINE)
.set_attr<FCompute>("FCompute<cpu>", UnaryOp::Compute<cpu,
mshadow_op::log_sigmoid>)
-.set_attr<nnvm::FGradient>("FGradient",
ElemwiseGradUseIn{"_backward_log_sigmoid"});
Review comment:
Thanks for the detailed analysis. The proposed change looks good and I
have no further concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
