RafLit opened a new pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463
## Description ##
This PR is a followup to #20356 and includes further code formatting
changes.
- added includes flagged by cpplint
- sorted the includes with clang-format
The clang-format config used for formatting:
```
---
Language: Cpp
BasedOnStyle: Google
ColumnLimit: 100
AlignConsecutiveAssignments: true
AlignConsecutiveDeclarations: false
AlignConsecutiveMacros: true
DerivePointerAlignment: false
SortIncludes: true
MaxEmptyLinesToKeep: 1
PointerAlignment: Left
AllowAllParametersOfDeclarationOnNextLine: false
AllowShortBlocksOnASingleLine: false
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: Empty
AllowShortIfStatementsOnASingleLine: false
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: true
BinPackArguments: false
BinPackParameters: false
SortIncludes: true
IncludeBlocks: Regroup
IncludeCategories:
# Headers in <> from specific external libraries.
- Regex:
'<((mxnet)|(nnvm)|(dmlc)|(gtest))\/([-\/_A-Za-z0-9])+((\.h)|(\.hpp))>'
Priority: 1
# Headers in <> with extension.
- Regex: '<([-\/_A-Za-z0-9])+((\.h)|(\.hpp))>'
Priority: 2
# Headers in <> without extension.
- Regex: '<([-\/_A-Za-z0-9])+>'
Priority: 3
# Local (./) Headers in "" with extension.
- Regex: '"(\.\/)([-\/_A-Za-z0-9])+((\.h)|(\.hpp))"'
Priority: 4
# Local (../) Headers in "" with extension.
- Regex: '"(\.\.\/)+([-\/_A-Za-z0-9])+((\.h)|(\.hpp))"'
Priority: 5
# Headers in "" with extension.
- Regex: '"([-\/_A-Za-z0-9])+((\.h)|(\.hpp))"'
Priority: 6
```
In this PR I formatted the following files:
- src/operator/nn/mkldnn/* (for mkldnn_batch_dot-inl.h only the include
sorting)
- src/operator/quantization/mkldnn/*
- src/operator/subgraph/mkldnn/*
- tests/cpp/include/test_mkldnn.h (only the include sorting)
- tests/cpp/operator/mkldnn_operator_test.cc
- tests/cpp/operator/mkldnn_test.cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
