lanking520 commented on a change in pull request #20461:
URL: https://github.com/apache/incubator-mxnet/pull/20461#discussion_r676790330
##########
File path: java-package/build.gradle
##########
@@ -0,0 +1,113 @@
+plugins {
+ id "com.github.spotbugs" version "4.2.0" apply true
+}
+
+defaultTasks 'build'
+
+allprojects {
+ group 'incubator-mxnet.java-package'
Review comment:
org.apache.mxnet as the group name?
##########
File path:
java-package/integration/src/main/java/org/apache/mxnet/integration/IntegrationTest.java
##########
@@ -0,0 +1,407 @@
+package org.apache.mxnet.integration;
Review comment:
This should come after the header
##########
File path: java-package/mxnet-engine/src/main/include/mxnet/c_api.h
##########
@@ -0,0 +1,3149 @@
+/*
Review comment:
Since now you are under apache-mxnet project, you can take the c_api.h
directly from the repo instead of preserving a copy.
##########
File path: java-package/mxnet-engine/src/main/include/mxnet/c_api_1_8.h
##########
@@ -0,0 +1,3422 @@
+/*
Review comment:
why keeping this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
